From 993142d49274092c64a2d475aa726df3c323949d Mon Sep 17 00:00:00 2001 From: Steven Arcangeli Date: Wed, 13 Mar 2024 20:56:40 -0700 Subject: [PATCH] fix: set lsp.diagnostics_trigger_update=false by default Some LSP servers are less than consistent with pushing diagnostics. For this and other reasons, I think tying the symbol refresh to diagnostics is maybe not the best move. The first step I'm going to take is to make the default behavior use a simple change listener, like the treesitter backend. I may eventually deprecate and remove this behavior entirely. --- README.md | 5 ++--- doc/aerial.txt | 5 ++--- lua/aerial/config.lua | 5 ++--- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 2f04d60..50d8f46 100644 --- a/README.md +++ b/README.md @@ -518,9 +518,8 @@ require("aerial").setup({ }, lsp = { - -- Fetch document symbols when LSP diagnostics update. - -- If false, will update on buffer changes. - diagnostics_trigger_update = true, + -- If true, fetch document symbols when LSP diagnostics update. + diagnostics_trigger_update = false, -- Set to false to not update the symbols when there are LSP errors update_when_errors = true, diff --git a/doc/aerial.txt b/doc/aerial.txt index 90d1677..e63c238 100644 --- a/doc/aerial.txt +++ b/doc/aerial.txt @@ -327,9 +327,8 @@ OPTIONS *aerial-option }, lsp = { - -- Fetch document symbols when LSP diagnostics update. - -- If false, will update on buffer changes. - diagnostics_trigger_update = true, + -- If true, fetch document symbols when LSP diagnostics update. + diagnostics_trigger_update = false, -- Set to false to not update the symbols when there are LSP errors update_when_errors = true, diff --git a/lua/aerial/config.lua b/lua/aerial/config.lua index 7ba6ee6..003b7e3 100644 --- a/lua/aerial/config.lua +++ b/lua/aerial/config.lua @@ -313,9 +313,8 @@ local default_options = { }, lsp = { - -- Fetch document symbols when LSP diagnostics update. - -- If false, will update on buffer changes. - diagnostics_trigger_update = true, + -- If true, fetch document symbols when LSP diagnostics update. + diagnostics_trigger_update = false, -- Set to false to not update the symbols when there are LSP errors update_when_errors = true,