nvim-plugins/nvim-cmp
1
0
Fork 0
mirror of https://github.com/hrsh7th/nvim-cmp synced 2024-09-16 20:54:03 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: small windows no longer constantly throw errors (#1824)

Browse source 
The entries_win:open function will fail when either the width or
the height of the window is less than 1, which will result in the
nvim_win_set_cursor being passed a nil value for self.entries_win.win
instead of a number, which causes an error to constantly appear when
the window is small. Hence, a guard clause to check for whether
self.entries_win.win is nil is added to stop the error from occurring.

Also fixed the rarer 'height' must be a positive Integer error caused
by the window.update function, within the clause to draw the scrollbar
background. This error happens on small windows when pressing and
holding down the backspace key to delete a lot of characters at once.
The nvim_open_win function call to create the scrollbar
background throws the error when self.style.height is 0. Hence, an
additional check is added alongside the info.scrollable check which also
skips drawing the scrollbar thumb as it is not needed when the height is
0 and will result in a weird scrollbar thumb floating some distance
away from the text when holding down backspace to delete a lot of
characters.
This commit is contained in:
hankertrix 2024-03-22 02:02:15 +08:00 committed by GitHub
parent 6460f979b9
commit 53d80d4d0c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lua/cmp/utils/window.lua
View file

@ -133,7 +133,7 @@ end
---Update
window.update = function(self)
local info = self:info()
if info.scrollable then
if info.scrollable and self.style.height > 0 then
-- Draw the background of the scrollbar
if not info.border_info.visible then

9
lua/cmp/view/custom_entries_view.lua
View file

@ -212,7 +212,14 @@ custom_entries_view.open = function(self, offset, entries)
border = completion.border,
zindex = completion.zindex or 1001,
})
-- always set cursor when starting. It will be adjusted on the call to _select
-- Don't set the cursor if the entries_win:open function fails
-- due to the window's width or height being less than 1
if self.entries_win.win == nil then
return
end
-- Always set cursor when starting. It will be adjusted on the call to _select
vim.api.nvim_win_set_cursor(self.entries_win.win, { 1, 0 })
if preselect_index > 0 and config.get().preselect == types.cmp.PreselectMode.Item then
self:_select(preselect_index, { behavior = types.cmp.SelectBehavior.Select, active = false })